Feature/visible label and accessible name do not match #416
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniovsbasilio
requested review from
leo-prange-vtex,
vmourac-vtex and
vsseixaso
and removed request for
a team
Contributor
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
This PR fixes an accessibility mismatch between the visible text labels and the accessible names (aria-label) within the Product Summary components.
According to https://my2.siteimprove.com/ audits, interactive elements must have an accessible name that contains the visible text. Currently, some elements provide different strings for assistive technologies than what is displayed on the screen, which:
Confuses speech-input users who try to activate a button by its visible name.
Creates a disconnected experience for screen reader users.
It states:
The accessible name of any interactive element should contain its visible text label.
Using two different names for a single page element can create a confusing user experience for assistive technology users.
For example, speech-input users may have difficulty activating a control if the label displayed on-screen does not match its accessible name.
Screenshots or example usage: